Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: autolocation of node-gyp in make-spawn-args #221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: autolocation of node-gyp in make-spawn-args #221

wants to merge 1 commit into from

Conversation

legobeat
Copy link

@legobeat legobeat commented Sep 30, 2024 •
edited
Loading

  • Prevents runtime error in environments where require.resolve is not available.
  • Fall back to environment variable npm_config_node_gyp when node-gyp not resolved successfully.

Related

@legobeat legobeat force-pushed the safe-require-resolve branch 3 times, most recently from 18186ac to ceef07a Compare September 30, 2024 00:32
@legobeat legobeat marked this pull request as ready for review September 30, 2024 00:32
@legobeat legobeat requested a review from a team as a code owner September 30, 2024 00:32
@legobeat legobeat mentioned this pull request Sep 30, 2024
Open
@legobeat legobeat changed the title fix: defensive autolocation of node-gyp in make-spawn-args fix: autolocation of node-gyp in make-spawn-args Sep 30, 2024
legobeat
legobeat commented Sep 30, 2024
View reviewed changes
lib/make-spawn-args.js
let npm_config_node_gyp
try {
/* istanbul ignore next */
if (typeof require === 'function' && typeof require.resolve === 'function') {
Copy link
Author

@legobeat legobeat Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typeof require may seem redundant here considering we call require('path') just prior.

Rightfully or not, bundlers like webpack and esbuild may transform the direct require() calls but leave require.resolve intact. The extra check prevents runtime errors in such scenarios.

@legobeat legobeat force-pushed the safe-require-resolve branch 3 times, most recently from ceef07a to 2780f78 Compare September 30, 2024 01:35
This was referenced Sep 30, 2024
Open
Open
@legobeat
fix: defensive autolocation of node-gyp in make-spawn-args
c936a18 
prevents runtime error in environments where `require.resolve` is not
available

Fall back to any existing `npm_config_node_gyp` provided by environment
@legobeat
Copy link
Author

legobeat commented Oct 3, 2024 •
edited
Loading

@reggi @hashtagchris Some attention on this and #222 would be much appreciated if you are able to 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@legobeat